Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/agent: added missing syslog wrapper #168

Merged
merged 1 commit into from
May 22, 2014
Merged

command/agent: added missing syslog wrapper #168

merged 1 commit into from
May 22, 2014

Conversation

ryanuber
Copy link
Member

Builds in master seem to be failing since this file is missing. I just robbed it from Serf and builds are happy now.

@armon
Copy link
Member

armon commented May 22, 2014

Thanks! Looks like I forgot to commit this!

armon added a commit that referenced this pull request May 22, 2014
command/agent: added missing syslog wrapper
@armon armon merged commit 9cdeeba into hashicorp:master May 22, 2014
@ryanuber ryanuber deleted the syslog-wrapper branch May 22, 2014 17:42
duckhan pushed a commit to duckhan/consul that referenced this pull request Oct 24, 2021
Previously, we would write a service-defaults config regardless of the
value of the -default-protocol flag or the Pod's protocol annotation. If
neither of these were set, we would write a config with protocol set to
the empty string. This is the same as setting it to tcp. So for every
service, we were by default setting its protocol to tcp.

If a user explicitly created a global proxy-defaults config and set the
protocol to, say, http. Then our service-defaults config would override
that protocol. This behaviour was unexpected because users had never
explicitly told us to write a service-defaults config and it wasn't
helping them.

This change will cause us to only write a service-defaults config if the
protocol is explicitly set–either via the -default-protocol flag or via
the Pod annotation.

I've also renamed the CentralConfig field to WriteServiceDefaults
because there are many types of central config now so it's best to be
explicit.

Fixes hashicorp#168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants